gulp-validateTypedoc.js 25 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711
  1. 'use strict';
  2. var fs = require('fs');
  3. var Vinyl = require('vinyl');
  4. var path = require('path');
  5. var through = require('through2');
  6. var PluginError = require('plugin-error');
  7. var supportsColor = require('color-support');
  8. // ______________________________________________ LOGS ______________________________________________
  9. var hasColors = supportsColor();
  10. var red = hasColors ? '\x1b[31m' : '';
  11. var yellow = hasColors ? '\x1b[33m' : '';
  12. var green = hasColors ? '\x1b[32m' : '';
  13. var gray = hasColors ? '\x1b[90m' : '';
  14. var white = hasColors ? '\x1b[97m' : '';
  15. var clear = hasColors ? '\x1b[0m' : '';
  16. var currentColor = undefined;
  17. function getTimestamp() {
  18. var time = new Date();
  19. var timeInString = ("0" + time.getHours()).slice(-2) + ":" +
  20. ("0" + time.getMinutes()).slice(-2) + ":" +
  21. ("0" + time.getSeconds()).slice(-2);
  22. if (currentColor) {
  23. return white + '[' + currentColor + timeInString + clear + white + ']';
  24. }
  25. else {
  26. return white + '[' + gray + timeInString + white + ']';
  27. }
  28. }
  29. function log() {
  30. currentColor = gray;
  31. var time = getTimestamp();
  32. process.stdout.write(time + ' ');
  33. currentColor = undefined;
  34. console.log.apply(console, arguments);
  35. return this;
  36. }
  37. function warn() {
  38. currentColor = yellow;
  39. var time = getTimestamp();
  40. process.stdout.write(time + ' ');
  41. currentColor = undefined;
  42. console.warn.apply(console, arguments);
  43. return this;
  44. }
  45. function err() {
  46. currentColor = red;
  47. var time = getTimestamp();
  48. process.stderr.write(time + ' ');
  49. currentColor = undefined;
  50. console.error.apply(console, arguments);
  51. return this;
  52. }
  53. function success() {
  54. currentColor = green;
  55. var time = getTimestamp();
  56. process.stdout.write(time + ' ');
  57. currentColor = undefined;
  58. console.log.apply(console, arguments);
  59. return this;
  60. }
  61. // ______________________________________________ VALIDATION ____________________________________________
  62. function unixStylePath(filePath) {
  63. return filePath.replace(/\\/g, '/');
  64. }
  65. function Validate(validationBaselineFileName, namespaceName, validateNamingConvention, generateBaseLine) {
  66. this.validationBaselineFileName = validationBaselineFileName;
  67. this.namespaceName = namespaceName;
  68. this.validateNamingConvention = validateNamingConvention;
  69. this.generateBaseLine = generateBaseLine;
  70. this.previousResults = { };
  71. this.results = {
  72. errors: 0
  73. };
  74. }
  75. Validate.hasTag = function(node, tagName) {
  76. tagName = tagName.trim().toLowerCase();
  77. if (node.comment && node.comment.tags) {
  78. for (var i = 0; i < node.comment.tags.length; i++) {
  79. if (node.comment.tags[i].tag === tagName) {
  80. return true;
  81. }
  82. }
  83. }
  84. return false;
  85. }
  86. Validate.position = function(node) {
  87. if (!node.sources) {
  88. log(node);
  89. }
  90. return node.sources[0].fileName + ':' + node.sources[0].line;
  91. }
  92. Validate.upperCase = new RegExp("^[A-Z_]*$");
  93. Validate.pascalCase = new RegExp("^[A-Z][a-zA-Z0-9_]*$");
  94. Validate.camelCase = new RegExp("^[a-z][a-zA-Z0-9_]*$");
  95. Validate.underscoreCamelCase = new RegExp("^_[a-z][a-zA-Z0-9_]*$");
  96. Validate.underscorePascalCase = new RegExp("^_[A-Z][a-zA-Z0-9_]*$");
  97. Validate.prototype.errorCallback = function (parent, node, nodeKind, category, type, msg, position) {
  98. this.results[this.filePath] = this.results[this.filePath] || { errors: 0 };
  99. var results = this.results[this.filePath];
  100. if (node === "toString") {
  101. node = "ToString";
  102. }
  103. // Checks against previous results.
  104. var previousResults = this.previousResults[this.filePath];
  105. if (previousResults) {
  106. var previousRootName = parent ? parent : node;
  107. var needCheck = true;
  108. if (Array.isArray(previousRootName)) {
  109. while (previousRootName.length > 1) {
  110. var previousFirst = previousRootName.shift();
  111. previousResults = previousResults[previousFirst];
  112. if (!previousResults) {
  113. needCheck = false;
  114. break;
  115. }
  116. }
  117. previousRootName = previousRootName.shift();
  118. }
  119. if (needCheck) {
  120. var previousNode = previousResults[previousRootName];
  121. if (previousNode) {
  122. var previousNodeKind = previousNode[nodeKind];
  123. if (previousNodeKind) {
  124. if (parent) {
  125. previousNode = previousNodeKind[node];
  126. }
  127. else {
  128. previousNode = previousNodeKind;
  129. }
  130. if (previousNode) {
  131. var previousCategory = previousNode[category];
  132. if (previousCategory) {
  133. var previousType = previousCategory[type];
  134. if (previousType) {
  135. // Early exit as it was already in the previous build.
  136. return;
  137. }
  138. }
  139. }
  140. }
  141. }
  142. }
  143. }
  144. // Write Error in output JSON.
  145. var rootName = parent ? parent : node;
  146. var current = results;
  147. if (Array.isArray(rootName)) {
  148. while (rootName.length > 1) {
  149. var first = rootName.shift();
  150. current = current[first] = current[first] || { };
  151. }
  152. rootName = rootName.shift();
  153. }
  154. current = current[rootName] = current[rootName] || { };
  155. current = current[nodeKind] = current[nodeKind] || { };
  156. if (parent) {
  157. current = current[node] = current[node] || { };
  158. }
  159. current = current[category] = current[category] || { };
  160. current = current[type] = true;
  161. results.errors++;
  162. if (!this.generateBaseLine) {
  163. err(msg, position);
  164. }
  165. }
  166. Validate.prototype.init = function (cb) {
  167. var self = this;
  168. if (!this.generateBaseLine && fs.existsSync(this.validationBaselineFileName)) {
  169. fs.readFile(this.validationBaselineFileName, "utf-8", function (err, data) {
  170. self.previousResults = JSON.parse(data);
  171. cb();
  172. });
  173. }
  174. else {
  175. cb();
  176. }
  177. }
  178. Validate.prototype.add = function (filePath, content) {
  179. this.filePath = filePath && unixStylePath(filePath);
  180. if (!Buffer.isBuffer(content)) {
  181. content = new Buffer(content);
  182. }
  183. var contentString = content.toString();
  184. var json = JSON.parse(contentString);
  185. this.validateTypedoc(json);
  186. this.results.errors += this.results[this.filePath].errors;
  187. }
  188. Validate.prototype.getResults = function () {
  189. return this.results;
  190. }
  191. Validate.prototype.getContents = function () {
  192. return Buffer.from(JSON.stringify(this.results));
  193. }
  194. /**
  195. * Validate a TypeDoc JSON file
  196. */
  197. Validate.prototype.validateTypedoc = function (json) {
  198. var namespaces = json.children[0].children;
  199. var namespace = null;
  200. var containerNode;
  201. var childNode;
  202. var children;
  203. var signatures;
  204. var signatureNode;
  205. var tags;
  206. var isPublic;
  207. // Check for BABYLON namespace
  208. for (var child in namespaces) {
  209. if (namespaces[child].name === this.namespaceName) {
  210. namespace = namespaces[child];
  211. break;
  212. }
  213. }
  214. // Exit if not BABYLON related.
  215. if (!namespace || !namespace.children) {
  216. return;
  217. }
  218. // Validate Classes
  219. for (var a in namespace.children) {
  220. containerNode = namespace.children[a];
  221. // If comment contains @ignore then skip validation completely
  222. if (Validate.hasTag(containerNode, 'ignore')) continue;
  223. // Account for undefined access modifiers.
  224. if (!containerNode.flags.isPublic &&
  225. !containerNode.flags.isPrivate &&
  226. !containerNode.flags.isProtected) {
  227. containerNode.flags.isPublic = true;
  228. }
  229. isPublic = containerNode.flags.isPublic;
  230. // Validate naming.
  231. this.validateNaming(null, containerNode);
  232. // Validate Comments.
  233. if (isPublic && !this.validateComment(containerNode)) {
  234. this.errorCallback(null,
  235. containerNode.name,
  236. containerNode.kindString,
  237. "Comments",
  238. "MissingText",
  239. "Missing text for " + containerNode.kindString + " : " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(containerNode));
  240. }
  241. //if comment contains tag @ignoreChildren, then don't validate children
  242. var validateChildren = !Validate.hasTag(containerNode, 'ignoreChildren');
  243. children = containerNode.children;
  244. //Validate Properties
  245. if (validateChildren && children) {
  246. for (var b in children) {
  247. childNode = children[b];
  248. // Account for undefined access modifiers.
  249. if (!childNode.flags.isPublic &&
  250. !childNode.flags.isPrivate &&
  251. !childNode.flags.isProtected) {
  252. childNode.flags.isPublic = true;
  253. }
  254. isPublic = childNode.flags.isPublic;
  255. // Validate Naming.
  256. this.validateNaming(containerNode, childNode);
  257. //if comment contains @ignore then skip validation completely
  258. if (Validate.hasTag(childNode, 'ignore')) continue;
  259. if (isPublic) {
  260. tags = this.validateTags(childNode);
  261. if (tags) {
  262. this.errorCallback(containerNode.name,
  263. childNode.name,
  264. childNode.kindString,
  265. "Tags",
  266. tags,
  267. "Unrecognized tag " + tags + " at " + childNode.name + " (id: " + childNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  268. }
  269. }
  270. if (!this.validateComment(childNode)) {
  271. //Validate Signatures
  272. signatures = childNode.signatures;
  273. if (signatures) {
  274. for (var c in signatures) {
  275. signatureNode = signatures[c];
  276. //if node contains @ignore then skip validation completely
  277. if (Validate.hasTag(signatureNode, 'ignore')) continue;
  278. if (isPublic) {
  279. if (!this.validateComment(signatureNode)) {
  280. this.errorCallback(containerNode.name,
  281. signatureNode.name,
  282. childNode.kindString,
  283. "Comments",
  284. "MissingText",
  285. "Missing text for " + childNode.kindString + " : " + signatureNode.name + " (id: " + signatureNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  286. }
  287. tags = this.validateTags(signatureNode);
  288. if (tags) {
  289. this.errorCallback(containerNode.name,
  290. signatureNode.name,
  291. childNode.kindString,
  292. "Tags",
  293. tags,
  294. "Unrecognized tag " + tags + " at " + signatureNode.name + " (id: " + signatureNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  295. }
  296. if (signatureNode.type.name !== "void" && signatureNode.comment && !signatureNode.comment.returns) {
  297. this.errorCallback(containerNode.name,
  298. signatureNode.name,
  299. childNode.kindString,
  300. "Comments",
  301. "MissingReturn",
  302. "No Return Comment at " + signatureNode.name + " (id: " + signatureNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  303. }
  304. if (signatureNode.type.name === "void" && signatureNode.comment && signatureNode.comment.returns) {
  305. this.errorCallback(containerNode.name,
  306. signatureNode.name,
  307. childNode.kindString,
  308. "Comments",
  309. "UselessReturn",
  310. "No Return Comment Needed at " + signatureNode.name + " (id: " + signatureNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  311. }
  312. }
  313. this.validateParameters(containerNode, childNode, signatureNode, signatureNode.parameters, isPublic);
  314. }
  315. } else {
  316. this.errorCallback(containerNode.name,
  317. childNode.name,
  318. childNode.kindString,
  319. "Comments",
  320. "MissingText",
  321. "Missing text for " + childNode.kindString + " : " + childNode.name + " (id: " + childNode.id + ") in " + containerNode.name + " (id: " + containerNode.id + ")", Validate.position(childNode));
  322. }
  323. }
  324. // this.validateParameters(containerNode, childNode, childNode.parameters, isPublic);
  325. }
  326. }
  327. }
  328. }
  329. /**
  330. * Validate that tags are recognized
  331. */
  332. Validate.prototype.validateTags = function(node) {
  333. var tags;
  334. var errorTags = [];
  335. if (node.comment) {
  336. tags = node.comment.tags;
  337. if (tags) {
  338. for (var i = 0; i < tags.length; i++) {
  339. var tag = tags[i];
  340. var validTags = ["constructor", "throw", "type", "deprecated", "example", "examples", "remark", "see", "remarks"]
  341. if (validTags.indexOf(tag.tag) === -1) {
  342. errorTags.push(tag.tag);
  343. }
  344. }
  345. }
  346. }
  347. return errorTags.join(",");
  348. }
  349. /**
  350. * Validate that a JSON node has the correct TypeDoc comments
  351. */
  352. Validate.prototype.validateComment = function(node) {
  353. // Return-only methods are allowed to just have a @return tag
  354. if ((node.kindString === "Call signature" || node.kindString === "Accessor") && !node.parameters && node.comment && node.comment.returns) {
  355. return true;
  356. }
  357. // Return true for private properties (dont validate)
  358. if ((node.kindString === "Property" || node.kindString === "Object literal") && (node.flags.isPrivate || node.flags.isProtected)) {
  359. return true;
  360. }
  361. // Return true for inherited properties
  362. if (node.inheritedFrom) {
  363. return true;
  364. }
  365. if (node.comment) {
  366. if (node.comment.text || node.comment.shortText) {
  367. return true;
  368. }
  369. return false;
  370. }
  371. return false;
  372. }
  373. /**
  374. * Validate comments for paramters on a node
  375. */
  376. Validate.prototype.validateParameters = function(containerNode, method, signature, parameters, isPublic) {
  377. var parametersNode;
  378. for (var parameter in parameters) {
  379. parametersNode = parameters[parameter];
  380. if (isPublic && !this.validateComment(parametersNode)) {
  381. // throw containerNode.name + " " + method.kindString + " " + method.name + " " + parametersNode.name + " " + parametersNode.kindString;
  382. this.errorCallback([containerNode.name, method.kindString, signature.name],
  383. parametersNode.name,
  384. parametersNode.kindString,
  385. "Comments",
  386. "MissingText",
  387. "Missing text for parameter " + parametersNode.name + " (id: " + parametersNode.id + ") of " + method.name + " (id: " + method.id + ")", Validate.position(method));
  388. }
  389. if (this.validateNamingConvention && !Validate.camelCase.test(parametersNode.name)) {
  390. this.errorCallback([containerNode.name, method.kindString, signature.name],
  391. parametersNode.name,
  392. parametersNode.kindString,
  393. "Naming",
  394. "NotCamelCase",
  395. "Parameter " + parametersNode.name + " should be Camel Case (id: " + method.id + ")", Validate.position(method));
  396. }
  397. }
  398. }
  399. /**
  400. * Validate naming conventions of a node
  401. */
  402. Validate.prototype.validateNaming = function(parent, node) {
  403. if (!this.validateNamingConvention) {
  404. return;
  405. }
  406. if (node.inheritedFrom) {
  407. return;
  408. }
  409. // Internals are not subject to the public visibility policy.
  410. if (node.name && node.name.length > 0 && node.name[0] === "_") {
  411. return;
  412. }
  413. if ((node.flags.isPrivate || node.flags.isProtected) && node.flags.isStatic) {
  414. if (!Validate.underscorePascalCase.test(node.name)) {
  415. this.errorCallback(parent ? parent.name : null,
  416. node.name,
  417. node.kindString,
  418. "Naming",
  419. "NotUnderscorePascalCase",
  420. node.name + " should be Underscore Pascal Case (id: " + node.id + ")", Validate.position(node),
  421. );
  422. }
  423. }
  424. else if (node.flags.isPrivate || node.flags.isProtected) {
  425. if (!Validate.underscoreCamelCase.test(node.name)) {
  426. this.errorCallback(parent ? parent.name : null,
  427. node.name,
  428. node.kindString,
  429. "Naming",
  430. "NotUnderscoreCamelCase",
  431. node.name + " should be Underscore Camel Case (id: " + node.id + ")", Validate.position(node));
  432. }
  433. }
  434. else if (node.flags.isStatic) {
  435. if (!Validate.pascalCase.test(node.name)) {
  436. this.errorCallback(parent ? parent.name : null,
  437. node.name,
  438. node.kindString,
  439. "Naming",
  440. "NotPascalCase",
  441. node.name + " should be Pascal Case (id: " + node.id + ")", Validate.position(node));
  442. }
  443. }
  444. else if (node.kindString == "Module") {
  445. if (!Validate.upperCase.test(node.name)) {
  446. this.errorCallback(parent ? parent.name : null,
  447. node.name,
  448. node.kindString,
  449. "Naming",
  450. "NotUpperCase",
  451. "Module is not Upper Case " + node.name + " (id: " + node.id + ")", Validate.position(node));
  452. }
  453. }
  454. else if (node.kindString == "Interface" ||
  455. node.kindString == "Class" ||
  456. node.kindString == "Enumeration" ||
  457. node.kindString == "Enumeration member" ||
  458. node.kindString == "Accessor" ||
  459. node.kindString == "Type alias") {
  460. if (!Validate.pascalCase.test(node.name)) {
  461. this.errorCallback(parent ? parent.name : null,
  462. node.name,
  463. node.kindString,
  464. "Naming",
  465. "NotPascalCase",
  466. node.name + " should be Pascal Case (id: " + node.id + ")", Validate.position(node));
  467. }
  468. }
  469. else if (node.kindString == "Method" ||
  470. node.kindString == "Property" ||
  471. node.kindString == "Object literal") {
  472. // Only warn here as special properties such as FOV may be better capitalized
  473. if (!Validate.camelCase.test(node.name)) {
  474. this.errorCallback(parent ? parent.name : null,
  475. node.name,
  476. node.kindString,
  477. "Naming",
  478. "NotCamelCase",
  479. node.name + " should be Camel Case (id: " + node.id + ")", Validate.position(node));
  480. }
  481. }
  482. else if (node.kindString == "Variable") {
  483. this.errorCallback(parent ? parent.name : null,
  484. node.name,
  485. node.kindString,
  486. "Naming",
  487. "ShouldNotBeLooseVariable",
  488. node.name + " should not be a variable (id: " + node.id + ")", Validate.position(node));
  489. }
  490. else if (node.kindString === "Function") {
  491. if (!Validate.camelCase.test(node.name)) {
  492. this.errorCallback(parent ? parent.name : null,
  493. node.name,
  494. node.kindString,
  495. "Naming",
  496. "NotCamelCase",
  497. node.name + " should be Camel Case (id: " + node.id + ")", Validate.position(node));
  498. }
  499. }
  500. else if (node.kindString == "Constructor") {
  501. // Do Nothing Here, this is handled through the class name.
  502. }
  503. else {
  504. this.errorCallback(parent ? parent.name : null,
  505. node.name,
  506. node.kindString,
  507. "Naming",
  508. "UnknownNamingConvention",
  509. "Unknown naming convention for " + node.kindString + " at " + node.name + " (id: " + node.id + ")", Validate.position(node));
  510. }
  511. }
  512. // ______________________________________________ PLUGIN ____________________________________________
  513. // consts
  514. const PLUGIN_NAME = 'gulp-validateTypedoc';
  515. // plugin level function (dealing with files)
  516. function gulpValidateTypedoc(validationBaselineFileName, namespaceName, validateNamingConvention, generateBaseLine) {
  517. if (!validationBaselineFileName) {
  518. throw new PluginError(PLUGIN_NAME, 'Missing validation filename!');
  519. }
  520. if (typeof validationBaselineFileName !== "string") {
  521. throw new PluginError(PLUGIN_NAME, 'Validation filename must be a string!');
  522. }
  523. var validate;
  524. var latestFile;
  525. function bufferContents(file, enc, cb) {
  526. // ignore empty files
  527. if (file.isNull()) {
  528. cb();
  529. return;
  530. }
  531. // we don't do streams (yet)
  532. if (file.isStream()) {
  533. this.emit('error', new Error('gulp-validatTypedoc: Streaming not supported'));
  534. cb();
  535. return;
  536. }
  537. // set latest file if not already set,
  538. // or if the current file was modified more recently.
  539. latestFile = file;
  540. // What will happen once all set.
  541. var done = function () {
  542. // add file to concat instance
  543. validate.add(file.relative, file.contents);
  544. cb();
  545. }
  546. // Do the validation.
  547. if (!validate) {
  548. validate = new Validate(validationBaselineFileName, namespaceName, validateNamingConvention, generateBaseLine);
  549. validate.init(done);
  550. }
  551. else {
  552. done();
  553. }
  554. }
  555. function endStream(cb) {
  556. // no files passed in, no file goes out
  557. if (!latestFile) {
  558. var error = new PluginError(PLUGIN_NAME, 'gulp-validatTypedoc: No Baseline found.');
  559. this.emit('error', error);
  560. cb();
  561. return;
  562. }
  563. var results = validate.getResults();
  564. var buffer = Buffer.from(JSON.stringify(results, null, 2))
  565. if (generateBaseLine) {
  566. fs.writeFileSync(validationBaselineFileName, buffer || '');
  567. }
  568. var jsFile = new Vinyl({
  569. cwd: process.cwd,
  570. base: null,
  571. path: validationBaselineFileName,
  572. contents: buffer
  573. });
  574. this.push(jsFile);
  575. var action = generateBaseLine ? "baseline generation" : "validation";
  576. var error = function(message) {
  577. generateBaseLine ? warn : err;
  578. if (generateBaseLine) {
  579. warn(message);
  580. }
  581. else {
  582. err(message);
  583. var error = new PluginError(PLUGIN_NAME, message);
  584. this.emit('error', error);
  585. }
  586. }
  587. if (results.errors > 1) {
  588. var message = results.errors + " errors have been detected during the " + action + " !";
  589. error(message);
  590. }
  591. else if (results.errors === 1) {
  592. var message = "1 error has been detected during the " + action + " !";
  593. error(message);
  594. }
  595. else {
  596. var message = "All formatting check passed successfully during the " + action + " !";
  597. success(message);
  598. }
  599. cb();
  600. }
  601. return through.obj(bufferContents, endStream);
  602. };
  603. // exporting the plugin main function
  604. module.exports = gulpValidateTypedoc;