Browse Source

make sure we don't inject undefined values.

Raanan Weber 7 years ago
parent
commit
de129ae6f3
1 changed files with 4 additions and 2 deletions
  1. 4 2
      Viewer/src/viewer/viewer.ts

+ 4 - 2
Viewer/src/viewer/viewer.ts

@@ -816,12 +816,14 @@ export abstract class AbstractViewer {
         if (!config) return;
         Object.keys(config).forEach(key => {
             if (key in object && typeof object[key] !== 'function') {
-                if (typeof object[key] === 'function') return;
+                // if (typeof object[key] === 'function') return;
                 // if it is an object, iterate internally until reaching basic types
                 if (typeof object[key] === 'object') {
                     this.extendClassWithConfig(object[key], config[key]);
                 } else {
-                    object[key] = config[key];
+                    if (config[key] !== undefined) {
+                        object[key] = config[key];
+                    }
                 }
             }
         });