Browse Source

fix linting and documentation issues

Kacey Coley 6 years ago
parent
commit
aa6cddaa5f

+ 3 - 2
serializers/src/glTF/2.0/Extensions/KHR_lights_punctual.ts

@@ -40,7 +40,7 @@ interface ILights {
 /**
  * [Specification](https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_lights_punctual/README.md)
  */
-export class KHR_lights implements IGLTFExporterExtensionV2 {
+export class KHR_lights_punctual implements IGLTFExporterExtensionV2 {
     /** The name of this extension. */
     public readonly name = NAME;
 
@@ -94,6 +94,7 @@ export class KHR_lights implements IGLTFExporterExtensionV2 {
      * @param context The context when exporting the node
      * @param node glTF node
      * @param babylonNode BabylonJS node
+     * @returns nullable INode promise
      */
     public postExportNodeAsync(context: string, node: INode, babylonNode: Node): Nullable<Promise<INode>> {
         return new Promise((resolve, reject) => {
@@ -183,4 +184,4 @@ export class KHR_lights implements IGLTFExporterExtensionV2 {
     }
 }
 
-_Exporter.RegisterExtension(NAME, (exporter) => new KHR_lights(exporter));
+_Exporter.RegisterExtension(NAME, (exporter) => new KHR_lights_punctual(exporter));

+ 1 - 2
serializers/src/glTF/2.0/glTFExporter.ts

@@ -1268,7 +1268,7 @@ export class _Exporter {
                 // Build Hierarchy with the node map.
                 for (let babylonNode of nodes) {
                     glTFNodeIndex = this._nodeMap[babylonNode.uniqueId];
-                    if (glTFNodeIndex !== undefined) { 
+                    if (glTFNodeIndex !== undefined) {
                         glTFNode = this._nodes[glTFNodeIndex];
                         if (!babylonNode.parent) {
                             if (!this._shouldExportNode(babylonNode)) {
@@ -1341,7 +1341,6 @@ export class _Exporter {
                                 const directDescendents = babylonNode.getDescendants(true, (node: Node) => { return (node instanceof Node); });
                                 if (directDescendents.length || node.mesh != null || (node.extensions)) {
                                     this._nodes.push(node);
-                                    
                                     nodeIndex = this._nodes.length - 1;
                                     nodeMap[babylonNode.uniqueId] = nodeIndex;
                                 }

+ 2 - 0
serializers/src/glTF/2.0/glTFExporterExtension.ts

@@ -32,6 +32,7 @@ export interface IGLTFExporterExtensionV2 extends IGLTFExporterExtension, IDispo
      * @param meshPrimitive glTF mesh primitive
      * @param babylonSubMesh Babylon submesh
      * @param binaryWriter glTF serializer binary writer instance
+     * @returns nullable IMeshPrimitive promise
      */
     postExportMeshPrimitiveAsync?(context: string, meshPrimitive: IMeshPrimitive, babylonSubMesh: SubMesh, binaryWriter: _BinaryWriter): Nullable<Promise<IMeshPrimitive>>;
 
@@ -40,6 +41,7 @@ export interface IGLTFExporterExtensionV2 extends IGLTFExporterExtension, IDispo
      * @param context The context when exporting the node
      * @param node glTF node
      * @param babylonNode BabylonJS node
+     * @returns nullable INode promise
      */
     postExportNodeAsync?(context: string, node: INode, babylonNode: Node): Nullable<Promise<INode>>;