Prechádzať zdrojové kódy

Suggested solution to scenes/engines being disposed incorrectly

super.dispose() was nulling the rendering canvas, which prevented scene.detachControl to work.
Raanan Weber 6 rokov pred
rodič
commit
a9f4c1b53c
1 zmenil súbory, kde vykonal 2 pridanie a 2 odobranie
  1. 2 2
      src/Engines/engine.ts

+ 2 - 2
src/Engines/engine.ts

@@ -1903,8 +1903,6 @@ export class Engine extends ThinEngine {
     public dispose(): void {
     public dispose(): void {
         this.hideLoadingUI();
         this.hideLoadingUI();
 
 
-        super.dispose();
-
         this.onNewSceneAddedObservable.clear();
         this.onNewSceneAddedObservable.clear();
 
 
         // Release postProcesses
         // Release postProcesses
@@ -1953,6 +1951,8 @@ export class Engine extends ThinEngine {
             document.removeEventListener("webkitpointerlockchange", this._onPointerLockChange);
             document.removeEventListener("webkitpointerlockchange", this._onPointerLockChange);
         }
         }
 
 
+        super.dispose();
+
         // Remove from Instances
         // Remove from Instances
         var index = Engine.Instances.indexOf(this);
         var index = Engine.Instances.indexOf(this);