Преглед на файлове

Merge pull request #6992 from sebavan/master

Remove loaders dep to sceneHelpers
sebavan преди 5 години
родител
ревизия
985d23c731
променени са 2 файла, в които са добавени 1 реда и са изтрити 8 реда
  1. 1 0
      dist/preview release/what's new.md
  2. 0 8
      loaders/src/STL/stlFileLoader.ts

+ 1 - 0
dist/preview release/what's new.md

@@ -202,3 +202,4 @@
 - `Tools.QueueNewFrame` was removed in favor of `Engine.QueueNewFrame` ([Deltakosh](https://github.com/deltakosh/))
 - `Tools.QueueNewFrame` was removed in favor of `Engine.QueueNewFrame` ([Deltakosh](https://github.com/deltakosh/))
 - Removed external data from Engine (`addExternalData`, `getExternalData`, `getOrAddExternalDataWithFactory`, `removeExternalData`)  ([Deltakosh](https://github.com/deltakosh/))
 - Removed external data from Engine (`addExternalData`, `getExternalData`, `getOrAddExternalDataWithFactory`, `removeExternalData`)  ([Deltakosh](https://github.com/deltakosh/))
 - The glTF loader extensions that map to glTF 2.0 extensions will now be disabled if the extension is not present in `extensionsUsed`. ([bghgary](https://github.com/bghgary))
 - The glTF loader extensions that map to glTF 2.0 extensions will now be disabled if the extension is not present in `extensionsUsed`. ([bghgary](https://github.com/bghgary))
+- The STL loader does not create light or camera automatically, please use ```scene.createDefaultCameraOrLight();``` in your code [Sebavan](https://github.com/sebavan/)

+ 0 - 8
loaders/src/STL/stlFileLoader.ts

@@ -9,8 +9,6 @@ import { SceneLoader, ISceneLoaderPlugin, ISceneLoaderPluginExtensions } from "b
 import { AssetContainer } from "babylonjs/assetContainer";
 import { AssetContainer } from "babylonjs/assetContainer";
 import { Scene } from "babylonjs/scene";
 import { Scene } from "babylonjs/scene";
 
 
-import "babylonjs/Helpers/sceneHelpers";
-
 /**
 /**
  * STL file type loader.
  * STL file type loader.
  * This is a babylon scene loader plugin.
  * This is a babylon scene loader plugin.
@@ -125,12 +123,6 @@ export class STLFileLoader implements ISceneLoaderPlugin {
      */
      */
     public load(scene: Scene, data: any, rootUrl: string): boolean {
     public load(scene: Scene, data: any, rootUrl: string): boolean {
         var result = this.importMesh(null, scene, data, rootUrl, null, null, null);
         var result = this.importMesh(null, scene, data, rootUrl, null, null, null);
-
-        if (result) {
-            scene.createDefaultLight();
-            scene.createDefaultCameraOrLight();
-        }
-
         return result;
         return result;
     }
     }