Jelajahi Sumber

use string-number as version

Raanan Weber 5 tahun lalu
induk
melakukan
97a04271f8
1 mengubah file dengan 7 tambahan dan 1 penghapusan
  1. 7 1
      src/Cameras/XR/webXRFeaturesManager.ts

+ 7 - 1
src/Cameras/XR/webXRFeaturesManager.ts

@@ -183,12 +183,18 @@ export class WebXRFeaturesManager implements IDisposable {
         const name = typeof featureName === 'string' ? featureName : featureName.Name;
         let versionToLoad = 0;
         if (typeof version === 'string') {
+            if (!version) {
+                throw new Error(`Error in provided version - ${name} (${version})`);
+            }
             if (version === 'stable') {
                 versionToLoad = WebXRFeaturesManager.GetStableVersionOfFeature(name);
             } else if (version === 'latest') {
                 versionToLoad = WebXRFeaturesManager.GetLatestVersionOfFeature(name);
+            } else {
+                // try loading the number the string represents
+                versionToLoad = +version;
             }
-            if (versionToLoad === -1) {
+            if (versionToLoad === -1 ||  isNaN(versionToLoad)) {
                 throw new Error(`feature not found - ${name} (${version})`);
             }
         } else {