Fix camera dispose when using rigProcesses

Add type to onVRDisplayChangedObservable
Prevent onVRDisplayChangedObservable to be called twice

dist/preview release/babylon.max.js

@@ -15568,9 +15568,20 @@ var BABYLON;
                 this._rigCameras.pop().dispose();
             }
             // Postprocesses
-            var i = this._postProcesses.length;
-            while (--i >= 0) {
-                this._postProcesses[i].dispose(this);
+            if (this._rigPostProcess) {
+                this._rigPostProcess.dispose(this);
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            }
+            else if (this.cameraRigMode !== Camera.RIG_MODE_NONE) {
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            }
+            else {
+                var i = this._postProcesses.length;
+                while (--i >= 0) {
+                    this._postProcesses[i].dispose(this);
+                }
             }
             // Render targets
             var i = this.customRenderTargets.length;
@@ -15616,6 +15627,9 @@ var BABYLON;
             return this._rigCameras[1].getTarget();
         };
         Camera.prototype.setCameraRigMode = function (mode, rigParams) {
+            if (this.cameraRigMode === mode) {
+                return;
+            }
             while (this._rigCameras.length > 0) {
                 this._rigCameras.pop().dispose();
             }
@@ -67178,6 +67192,9 @@ var BABYLON;
             } };
             engine.onVRRequestPresentComplete.add(_this._onVREnabled);
             engine.initWebVR().add(function (event) {
+                if (_this._vrDevice === event.vrDisplay) {
+                    return;
+                }
                 _this._vrDevice = event.vrDisplay;
                 //reset the rig parameters.
                 _this.setCameraRigMode(BABYLON.Camera.RIG_MODE_WEBVR, { parentCamera: _this, vrDisplay: _this._vrDevice, frameData: _this._frameData, specs: _this._specsVersion });

dist/preview release/customConfigurations/minimalGLTFViewer/babylon.max.js

@@ -15568,9 +15568,20 @@ var BABYLON;
                 this._rigCameras.pop().dispose();
             }
             // Postprocesses
-            var i = this._postProcesses.length;
-            while (--i >= 0) {
-                this._postProcesses[i].dispose(this);
+            if (this._rigPostProcess) {
+                this._rigPostProcess.dispose(this);
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            }
+            else if (this.cameraRigMode !== Camera.RIG_MODE_NONE) {
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            }
+            else {
+                var i = this._postProcesses.length;
+                while (--i >= 0) {
+                    this._postProcesses[i].dispose(this);
+                }
             }
             // Render targets
             var i = this.customRenderTargets.length;
@@ -15616,6 +15627,9 @@ var BABYLON;
             return this._rigCameras[1].getTarget();
         };
         Camera.prototype.setCameraRigMode = function (mode, rigParams) {
+            if (this.cameraRigMode === mode) {
+                return;
+            }
             while (this._rigCameras.length > 0) {
                 this._rigCameras.pop().dispose();
             }
@@ -67178,6 +67192,9 @@ var BABYLON;
             } };
             engine.onVRRequestPresentComplete.add(_this._onVREnabled);
             engine.initWebVR().add(function (event) {
+                if (_this._vrDevice === event.vrDisplay) {
+                    return;
+                }
                 _this._vrDevice = event.vrDisplay;
                 //reset the rig parameters.
                 _this.setCameraRigMode(BABYLON.Camera.RIG_MODE_WEBVR, { parentCamera: _this, vrDisplay: _this._vrDevice, frameData: _this._frameData, specs: _this._specsVersion });

src/Cameras/VR/babylon.webVRCamera.ts

@@ -99,6 +99,9 @@ module BABYLON {
             this._onVREnabled = (success: boolean) => { if (success) { this.initControllers(); } };
             engine.onVRRequestPresentComplete.add(this._onVREnabled);
             engine.initWebVR().add((event: IDisplayChangedEventArgs) => {
+                if (this._vrDevice === event.vrDisplay) {
+                    return;
+                }
 
                 this._vrDevice = event.vrDisplay;
 

src/Cameras/babylon.camera.ts

@@ -609,9 +609,19 @@
             }
 
             // Postprocesses
-            var i = this._postProcesses.length;
-            while (--i >= 0) {
-                this._postProcesses[i].dispose(this);
+            if (this._rigPostProcess) {
+                this._rigPostProcess.dispose(this);
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            }
+            else if (this.cameraRigMode !== Camera.RIG_MODE_NONE) {
+                this._rigPostProcess = null;
+                this._postProcesses = [];
+            } else {
+                var i = this._postProcesses.length;
+                while (--i >= 0) {
+                    this._postProcesses[i].dispose(this);
+                }
             }
 
             // Render targets
@@ -657,6 +667,10 @@
         }
 
         public setCameraRigMode(mode: number, rigParams: any): void {
+            if (this.cameraRigMode === mode) {
+                return;
+            }
+
             while (this._rigCameras.length > 0) {
                 this._rigCameras.pop().dispose();
             }

src/babylon.engine.ts

@@ -1598,7 +1598,7 @@
             return this._vrDisplay;
         }
 
-        public initWebVR(): Observable<any> {
+        public initWebVR(): Observable<{vrDisplay: any, vrSupported: any}> {
             var notifyObservers = () => {
                 var eventArgs = {
                     vrDisplay: this._vrDisplay,