Quellcode durchsuchen

Fix in Geometry.copy()

Without this fix, two geometries which have been copied share the same vertex data arrays. This leads to unexpected behaviour, e.g. infinite loop when trying to merge meshes.
jahow vor 10 Jahren
Ursprung
Commit
70ebd7287c
1 geänderte Dateien mit 3 neuen und 2 gelöschten Zeilen
  1. 3 2
      Babylon/Mesh/babylon.geometry.ts

+ 3 - 2
Babylon/Mesh/babylon.geometry.ts

@@ -394,7 +394,8 @@
             var stopChecking = false;
 
             for (var kind in this._vertexBuffers) {
-                vertexData.set(this.getVerticesData(kind), kind);
+                // using slice() to make a copy of the array and not just reference it
+                vertexData.set(this.getVerticesData(kind).slice(0), kind);
 
                 if (!stopChecking) {
                     updatable = this.getVertexBuffer(kind).isUpdatable();
@@ -729,4 +730,4 @@
             }
         }
     }
-} 
+}