Explorar o código

disposing correctly

Raanan Weber %!s(int64=7) %!d(string=hai) anos
pai
achega
5e66b30f2f
Modificáronse 2 ficheiros con 6 adicións e 0 borrados
  1. 4 0
      Viewer/src/model/viewerModel.ts
  2. 2 0
      Viewer/src/viewer/viewer.ts

+ 4 - 0
Viewer/src/model/viewerModel.ts

@@ -289,6 +289,10 @@ export class ViewerModel implements IDisposable {
     }
 
     public dispose() {
+        this.onAfterConfigure.clear();
+        this.onLoadedObservable.clear();
+        this.onLoadErrorObservable.clear();
+        this.onLoadProgressObservable.clear();
         if (this.loader && this.loader.name === "gltf") {
             (<GLTFFileLoader>this.loader).dispose();
         }

+ 2 - 0
Viewer/src/viewer/viewer.ts

@@ -573,6 +573,8 @@ export abstract class AbstractViewer {
             this.scene.activeCamera.detachControl(this.canvas);
         }
 
+        this.modelLoader.dispose();
+
         this.models.forEach(model => {
             model.dispose();
         });