ソースを参照

Inspector : Rename "onGlobalPropertyChange" to "onPropertyChangedObservable" part 2

Jaskar 7 年 前
コミット
5644fb3d2e

+ 1 - 1
inspector/src/Inspector.ts

@@ -44,7 +44,7 @@ module INSPECTOR {
                     //Load properties of GUI objects now as BABYLON.GUI has to be declared before 
                     loadGUIProperties();
                 }, () => {
-                    console.warn("Please add script https://preview.babylonjs.com/gui/babylon.gui.js to the HTML file")
+                    console.warn('Error : loading "babylon.gui.js". Please add script https://preview.babylonjs.com/gui/babylon.gui.js to the HTML file.');
                 });
             }
             else {

+ 0 - 2
inspector/src/details/PropertyLine.ts

@@ -293,10 +293,8 @@ module INSPECTOR {
          * Dispose all viewer element (color, texture...)
          */
         public dispose() {
-            // console.log('delete properties', this.name);
             Scheduler.getInstance().remove(this);
             for (let child of this._children) {
-                // console.log('delete properties', child.name);
                 Scheduler.getInstance().remove(child);
             }
             for (let elem of this._elements) {

+ 2 - 2
inspector/src/helpers/Helpers.ts

@@ -172,11 +172,11 @@ module INSPECTOR {
                         style.textContent = elem as string;
                     });
                 }, undefined, undefined, undefined, () => {
-                    console.log("erreur");
+                    console.log('Error : LoadFile "glsl.min.js"');
                 });
 
             }, undefined, undefined, undefined, () => {
-                console.log("erreur");
+                console.log('Error : LoadFile "highlight.min.js"')
             });
 
         }

+ 2 - 2
inspector/src/tabs/ConsoleTab.ts

@@ -92,10 +92,10 @@ module INSPECTOR {
 
         private _message(type:string, message:any, caller:string) {
             let callerLine = Helpers.CreateDiv('caller', this._consolePanelContent);
-            callerLine.textContent = caller;
+            callerLine.textContent = caller.replace(' ', '\u00A0');
 
             let line = Helpers.CreateDiv(type, this._consolePanelContent); 
-            line.textContent += message ; 
+            line.textContent = message.replace(' ', '\u00A0');
 
             this._consolePanelContent.scrollTop = this._consolePanelContent.scrollHeight; 
         }

+ 3 - 1
src/Debug/babylon.debugLayer.ts

@@ -12,7 +12,7 @@ module BABYLON {
 
         private BJSINSPECTOR = typeof INSPECTOR !== 'undefined' ? INSPECTOR : undefined;
 
-        public onPropertyChangedObservable = new Observable<{ object: any, property: string, value: any, initialValue: any }>();
+        public onPropertyChangedObservable: BABYLON.Observable<{ object: any, property: string, value: any, initialValue: any }>;
 
         constructor(scene: Scene) {
             this._scene = scene;
@@ -58,6 +58,7 @@ module BABYLON {
                 } catch (e) {
                     // If the inspector has been removed directly from the inspector tool
                 }
+                this.onPropertyChangedObservable.clear();
                 this._inspector = null;
             }
         }
@@ -104,6 +105,7 @@ module BABYLON {
             } else {
                 // Otherwise creates the inspector
                 this._createInspector(config);
+                this.onPropertyChangedObservable = new BABYLON.Observable<{ object: any, property: string, value: any, initialValue: any }>();
             }
         }