Browse Source

beforeRender should be executed after camera.update
Otherwise the camera's position will be wrong when using onBeforeRender
It is solving https://github.com/BabylonJS/Babylon.js/issues/3873

Raanan Weber 7 years ago
parent
commit
450b46491f
1 changed files with 3 additions and 3 deletions
  1. 3 3
      src/babylon.scene.ts

+ 3 - 3
src/babylon.scene.ts

@@ -3706,9 +3706,6 @@
                 this._gamepadManager._checkGamepadsStatus();
                 this._gamepadManager._checkGamepadsStatus();
             }
             }
 
 
-            // Before render
-            this.onBeforeRenderObservable.notifyObservers(this);
-
             // Update Cameras
             // Update Cameras
             if (this.activeCameras.length > 0) {
             if (this.activeCameras.length > 0) {
                 for (var cameraIndex = 0; cameraIndex < this.activeCameras.length; cameraIndex++) {
                 for (var cameraIndex = 0; cameraIndex < this.activeCameras.length; cameraIndex++) {
@@ -3731,6 +3728,9 @@
                 }
                 }
             }
             }
 
 
+            // Before render
+            this.onBeforeRenderObservable.notifyObservers(this);
+
             // Customs render targets
             // Customs render targets
             this.OnBeforeRenderTargetsRenderObservable.notifyObservers(this);
             this.OnBeforeRenderTargetsRenderObservable.notifyObservers(this);
             var engine = this.getEngine();
             var engine = this.getEngine();