Browse Source

Merge pull request #6706 from QuintusHegie/master

Fix for case when options.cap = Mesh.NO_CAP
David Catuhe 6 years ago
parent
commit
25940d6ee7
1 changed files with 1 additions and 1 deletions
  1. 1 1
      src/Meshes/Builders/cylinderBuilder.ts

+ 1 - 1
src/Meshes/Builders/cylinderBuilder.ts

@@ -16,7 +16,7 @@ VertexData.CreateCylinder = function(options: { height?: number, diameterTop?: n
     var subdivisions: number = options.subdivisions || 1;
     var hasRings: boolean = options.hasRings ? true : false;
     var enclose: boolean = options.enclose ? true : false;
-    var cap = options.cap || Mesh.CAP_ALL;
+    var cap = (options.cap === 0) ? 0 : options.cap || Mesh.CAP_ALL;
     var arc: number = options.arc && (options.arc <= 0 || options.arc > 1) ? 1.0 : options.arc || 1.0;
     var sideOrientation: number = (options.sideOrientation === 0) ? 0 : options.sideOrientation || VertexData.DEFAULTSIDE;
     var faceUV: Vector4[] = options.faceUV || new Array<Vector4>(3);