Selaa lähdekoodia

Merge pull request #6541 from sebavan/master

Fix cylinder broken normals / ios
sebavan 6 vuotta sitten
vanhempi
commit
18855d7c66
1 muutettua tiedostoa jossa 4 lisäystä ja 2 poistoa
  1. 4 2
      src/Meshes/Builders/cylinderBuilder.ts

+ 4 - 2
src/Meshes/Builders/cylinderBuilder.ts

@@ -8,6 +8,8 @@ VertexData.CreateCylinder = function(options: { height?: number, diameterTop?: n
     var height: number = options.height || 2;
     var diameterTop: number = (options.diameterTop === 0) ? 0 : options.diameterTop || options.diameter || 1;
     var diameterBottom: number = (options.diameterBottom === 0) ? 0 : options.diameterBottom || options.diameter || 1;
+    diameterTop = diameterTop || 0.00001; // Prevent broken normals
+    diameterBottom = diameterBottom || 0.00001; // Prevent broken normals
     var tessellation: number = options.tessellation || 24;
     var subdivisions: number = options.subdivisions || 1;
     var hasRings: boolean = options.hasRings ? true : false;
@@ -239,11 +241,11 @@ VertexData.CreateCylinder = function(options: { height?: number, diameterTop?: n
     // add caps to geometry based on cap parameter
     if ((cap === Mesh.CAP_START)
         || (cap === Mesh.CAP_ALL)) {
-        createCylinderCap(false);
+        createCylinderCap(false);
     }
     if ((cap === Mesh.CAP_END)
         || (cap === Mesh.CAP_ALL)) {
-        createCylinderCap(true);
+        createCylinderCap(true);
     }
 
     // Sides